Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Downloader hangs when executed with no items #877

Merged
shana merged 5 commits into from
Aug 1, 2018
Merged

Downloader hangs when executed with no items #877

shana merged 5 commits into from
Aug 1, 2018

Conversation

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Jul 31, 2018 •
edited
Loading

Might be related to: #841

Depends on:

Testing local builds, where the conditions for downloading resources are slightly different.
I found an issue where the Downloader will hang when RunSynchronously is called with no items in the queue.

Unity/src/GitHub.Api/Installer/GitInstaller.cs

Lines 260 to 264 in 675714a

if (!state.GitZipExists && !state.GitIsValid && state.GitPackage != null)
downloader.QueueDownload(state.GitPackage.Uri, installDetails.ZipPath);
if (!state.GitLfsZipExists && !state.GitLfsIsValid && state.GitLfsPackage != null)
downloader.QueueDownload(state.GitLfsPackage.Uri, installDetails.ZipPath);
downloader.RunSynchronously();

It hangs because TrySetResult/TrySetException is never called.

@StanleyGoldman StanleyGoldman mentioned this pull request Aug 1, 2018
Closed
@StanleyGoldman StanleyGoldman force-pushed the fixes/empty-task-queue branch from c2df2a5 to 801d033 Compare August 1, 2018 17:09
@shana shana merged commit d586e14 into master Aug 1, 2018
@shana shana deleted the fixes/empty-task-queue branch August 1, 2018 17:40
@drguthals drguthals mentioned this pull request Oct 10, 2018
Closed
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

ready-for-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanleyGoldman @shana