This repository was archived by the owner on Dec 5, 2024. It is now read-only.

This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Overlays in asset explorer only show for repositories with a remote #910

Closed

Assignees

Labels

opened

on Sep 17, 2018

Description

Steps to Reproduce

Create a new Unity project and initialize the GitHub extension
Initialize the project
Add some new assets to the project
Open the Project view and look under assets.

Expected behavior:
Overlay on new or modified assets should appear.

Actual behavior:
The overlay does not appear on assets without a remote.

The piece of code that needs to be fixed is here:

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs

Lines 29 to 44 in 484d6a9

    
           private static bool IsInitialized { get { return Repository != null && Repository.CurrentRemote.HasValue; } } 
        
           public static void Initialize(IApplicationManager theManager) 
        
           { 
        
               EditorApplication.projectWindowItemOnGUI -= OnProjectWindowItemGUI; 
        
               EditorApplication.projectWindowItemOnGUI += OnProjectWindowItemGUI; 
        
               manager = theManager; 
        
               if (IsInitialized) 
        
               { 
        
                   Repository.StatusEntriesChanged += RepositoryOnStatusEntriesChanged; 
        
                   Repository.LocksChanged += RepositoryOnLocksChanged; 
        
                   ValidateCachedData(); 
        
               } 
        
           }

Metadata

Assignees

StanleyGoldman

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests