This repository was archived by the owner on Jan 31, 2019. It is now read-only.
Fix Asana exceptions when parsing non-existent Asana task IDs #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmos
added a commit
that referenced
this pull request
May 14, 2014
Fix Asana exceptions when parsing non-existent Asana task IDs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes exceptions we're seeing when we parse references to non-existent Asana task IDs. Take the following commit message:
"Merge pull request #42. Fixes Asana #123456789."
When we try to post to the story 42 Asana has no idea what we're talking about and responds with a
400. Since this is a common scenario I've updated it to explicitly ignore400response codes.For non-2xx status codes we were also trying to raise a configuration error with
res.messagewhich is undefined onFaraday::Response. I've updated that to try to pull the error message from the JSON body./cc @atmos @izuzak @kdaigle