Add Typetalk service by dragon3 · Pull Request #825 · github/github-services · GitHub

This repository was archived by the owner on Jan 31, 2019. It is now read-only.

Contributor

dragon3 commented Apr 7, 2014

Typetalk is a chat service like HipChat or Campfire.
https://typetalk.in


          Add Typetalk service

d224aab

atmos reviewed

View reviewed changes

lib/services/typetalk.rb Outdated

Contributor

atmos Apr 7, 2014

Please read the contribution guidelines we don't accept new services that are based on the Service class anymore.

Contributor

atmos commented Apr 7, 2014

Feel free to reopen this once the code is updated.

atmos closed this


          Change base class from Service to Service::HttpPost

330490a

Contributor Author

dragon3 commented Apr 8, 2014

@atmos Thank you for your review.
I've fixed it on dragon3/github-services@330490a .
Could you please reopen this?

Contributor Author

dragon3 commented Apr 9, 2014

Hi @atmos
I can't reopen this, so is it better that I create a new pull request?

Contributor

atmos commented Apr 9, 2014

I'm traveling right now but can take a look in a few days.

atmos reopened this

Contributor Author

dragon3 commented Apr 10, 2014

Thanks!
Have a nice travel.

Contributor Author

dragon3 commented Apr 20, 2014

Hi!
Any update?
Please let me know if you have any questions or I should modify/update something.
Thanks.

atmos added a commit that referenced this pull request


          Merge pull request #825 from dragon3/typetalk

4fafefc

Add Typetalk service

atmos merged commit 4fafefc into github:master

Contributor

atmos commented Apr 20, 2014

@dragon3 Yeah, it should be live tomorrow.

Contributor Author

dragon3 commented Apr 21, 2014

@atmos Thanks! 👍

Contributor Author

dragon3 commented Apr 22, 2014

@atmos I can't select this service on repository settings yet. When will it be live?

Contributor Author

dragon3 commented Apr 23, 2014

Now I can use this service.
Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet