Remove disable_combine_sarif_files feature flag
#2991
+28
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the disable_combine_sarif_files feature flag which is currently fully enabled and no longer needed. The change simplifies the codebase by removing feature flag checks and directly applying the behavior that was previously controlled by the flag.
- Removes the
DisableCombineSarifFilesfeature flag enum value and configuration - Updates function signatures to remove the
featuresparameter from SARIF file combination logic - Simplifies test cases by removing feature flag-related test setup and scenarios
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/upload-lib.ts | Removes feature flag parameter from functions and simplifies SARIF file combination logic |
| src/upload-lib.test.ts | Updates test cases to remove feature flag dependencies and removes redundant test |
| src/feature-flags.ts | Removes the DisableCombineSarifFiles enum value and configuration |
| lib/upload-lib.test.js | Generated JavaScript equivalent of test file changes |
| lib/upload-lib.js | Generated JavaScript equivalent of main implementation changes |
| lib/feature-flags.js | Generated JavaScript equivalent of feature flag removal |
|
For the failing tests, it's probably easiest to wait for CLI 2.16.6 support to be dropped (which I suggested here). |
BoomchainLabs
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
disable_combine_sarif_filesfeature flag which is currently fully enabled.Merge / deployment checklist