Java: Move extractorInformationSkipKey predicate to library pack
#20134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85b2afa to
56cd9e7
Compare
56cd9e7 to
ac52a1b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a compilation error by moving the extractorInformationSkipKey extensible predicate from the codeql/java-queries pack to the codeql/java-all library pack. The issue occurred because an extensible predicate was declared in the same pack that was trying to extend it, which is not allowed in CodeQL.
Key changes:
- Moved the
extractorInformationSkipKeypredicate definition fromExtractorInformation.qlto the library fileDiagnostics.qll - Updated all extension configuration files to reference the correct pack (
codeql/java-allinstead ofcodeql/java-queries)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| java/ql/src/Telemetry/ExtractorInformation.yml | Updated pack reference from codeql/java-queries to codeql/java-all |
| java/ql/src/Telemetry/ExtractorInformation.ql | Removed the extensible predicate declaration |
| java/ql/lib/semmle/code/java/Diagnostics.qll | Added the extensible predicate with documentation |
| java/ql/integration-tests/kotlin/all-platforms/extractor_information_kotlin2/ExtractorInformation.ext.yml | Updated pack reference from codeql/java-queries to codeql/java-all |
| java/ql/integration-tests/kotlin/all-platforms/extractor_information_kotlin1/ExtractorInformation.ext.yml | Updated pack reference from codeql/java-queries to codeql/java-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation error where extensible predicate was declared in the same pack that was trying to extend it.
See internal PR for more details.