feat: Added Focus Toggle for DropdownMenu TrailingIcon Button #172753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

AlsoShantanuBorkar wants to merge 4 commits into flutter:master from AlsoShantanuBorkar:feat/dropdown-menu-trailing-icon-focus

+52 −0

AlsoShantanuBorkar commented Jul 25, 2025 •

edited

Loading

Added an API to toggle the focus of DropdownMenu Trailing IconButton.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

AlsoShantanuBorkar added 2 commits

July 25, 2025 13:35


          feat: Added Focus Toggle for DropdownMenu TrailingIcon Button

82589b7


          remove: unused import

905d0be

github-actions bot added framework f: material design labels

AlsoShantanuBorkar added 2 commits

July 27, 2025 11:32


          fix: license header

20ac5ef


          Merge branch 'master' into feat/dropdown-menu-trailing-icon-focus

6eda654

Contributor

SalehTZ commented Jul 27, 2025 •

edited

Loading

I think the test Using keyboard navigation to select and without setting the FocusNode parameter in file dropdown_menu_test.dart line:4166 is failing. See how the changes affect this test.

https://github.com/AlsoShantanuBorkar/flutter/blob/6eda6544640d3d488eeebce3d531c38e01170a7b/packages/flutter/test/material/dropdown_menu_test.dart#L4134-L4180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design framework