[draft] range slider should have 2 focus node #172729
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
internal: b/430179234 : in a11y mode, you can't use tab to focus on the handles of the rangeslider, only use a11y shortcut to focus on them.
rangeSlider is a widget with 1 renderObject but 2 semanticsNode because it has 2 inputs, each handle of the rangeSlider has its own actions. To achieve that, rangeSlider creates its semantics node using the assembleSemantics function.
For the same reason, rangeSlider should have 2 focus nodes instead of 1, and it should be linked to semantics to support tab to navigate in a11y mode.
This PR is to add 2 focus nodes to the range slider, link them to a11y and also highlight the thumb when focused.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.