Skip to content

Revert "add spaces before jump to header links" #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

Revert "add spaces before jump to header links" #1301

merged 1 commit into from
Jun 2, 2020

Conversation

strdr4605
Copy link
Contributor

@strdr4605 strdr4605 commented May 26, 2020 •
edited
Loading

#1215

This reverts commit f65592e.

Demo

Also, in another branch, there is a version with different emoji

Demo2

So if you like another option I can update this PR

@alubbe
Copy link
Member

alubbe commented May 26, 2020

Both icons are quite bulky, but I don't see any better option - what do you think @Siemienik @Alanscut ?

Siemienik
Siemienik approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fine for me

@alubbe alubbe merged commit 4a3ccf0 into exceljs:master Jun 2, 2020
This was referenced Dec 10, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strdr4605 @alubbe @Siemienik