Skip to content

Allow PHP 8 (and fixed a bug) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2021
Merged

Allow PHP 8 (and fixed a bug) #19

merged 1 commit into from
Feb 6, 2021

Conversation

zluiten
Copy link
Contributor

@zluiten zluiten commented Jan 30, 2021 •
edited
Loading

  • Allow PHP 8
  • Updated (dev) dependencies
  • Updated doc header with copyright year
  • Bugfix: replaced substr_replace with str_replace

https://github.com/event-engine/php-postgres-document-store/pull/19/files#diff-ad1ae52731163ed5a6715e9d147add200190335b38be36753cbc0c43e5689e73L830

- substr_replace(' 1 != 1 ', ' 1 = 1 ', $innerFilterStr),
+ str_replace(' 1 != 1 ', ' 1 = 1 ', $innerFilterStr),

This might affect #18, but that is purely based on looking at the code.

@zluiten
- Allow PHP 8
7ad5feb 
- Updated (dev) dependencies
- Bugfix: replaced substr_replace with str_repalce
- Updated doc header with copyright year
@codeliner
Copy link

codeliner commented Feb 6, 2021 •
edited
Loading

👍 good catch

@codeliner codeliner merged commit 51cdac6 into event-engine:master Feb 6, 2021
@codeliner codeliner mentioned this pull request Feb 6, 2021
Closed
@zluiten zluiten deleted the feature/php8 branch February 6, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeliner codeliner codeliner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zluiten @codeliner