Skip to content

fix: 'make fix-golint' is broken #6781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zirain merged 2 commits into from
Aug 12, 2025
Merged

fix: 'make fix-golint' is broken #6781

zirain merged 2 commits into from
Aug 12, 2025

Conversation

@shahar-h
Copy link
Contributor

@shahar-h shahar-h commented Aug 12, 2025

What this PR does / why we need it:
When running make fix-golint it fails with the following error:

===========> Running lint.fix-golint ... 
/Library/Developer/CommandLineTools/usr/bin/make lint.golint GOLANGCI_LINT_FLAGS="--fix"
===========> Running lint.golint ... 
find . -name "*.go" | xargs go tool gci write --skip-generated -s Standard -s Default -s "Prefix(github.com/envoyproxy/gateway)"
package github.com/daixiang0/gci/cmd/gci is not a main package
make[1]: *** [lint.fix-golint] Error 1
make: *** [_run] Error 2

According to golangci-lint docs gci supports autofix so gci tool can be removed.
I also verified this by reordering some import and then running make fix-golint which reordered it to the original state.

Release Notes: No

@shahar-h
fix: fix broken 'make fix-golint'
21cc6c1 
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@shahar-h
remove gci from tools directive
e992dfe 
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@shahar-h shahar-h requested a review from a team as a code owner August 12, 2025 18:54
@shahar-h shahar-h changed the title Fix fix golint fix: 'make fix-golint' is broken Aug 12, 2025
@codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.02%. Comparing base (34f641a) to head (e992dfe).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6781   +/-   ##
=======================================
  Coverage   71.02%   71.02%           
=======================================
  Files         225      225           
  Lines       39620    39620           
=======================================
+ Hits        28139    28141    +2     
+ Misses       9821     9820    -1     
+ Partials     1660     1659    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shahar-h
Copy link
Contributor Author

shahar-h commented Aug 12, 2025

/retest

@arkodg arkodg requested a review from zirain August 12, 2025 20:00
@arkodg arkodg added this to the v1.6.0-rc.1 Release milestone Aug 12, 2025
@zirain zirain merged commit 589fd5c into envoyproxy:main Aug 12, 2025
51 of 53 checks passed
@shahar-h shahar-h deleted the fix-fix-golint branch August 13, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zirain zirain zirain approved these changes

@arkodg arkodg arkodg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.6.0-rc.1 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@shahar-h @zirain @arkodg