Skip to content

ci: fix changes job #6748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zirain merged 1 commit into from
Aug 11, 2025
Merged

ci: fix changes job #6748

zirain merged 1 commit into from
Aug 11, 2025

Conversation

@zirain
Copy link
Member

@zirain zirain commented Aug 9, 2025 •
edited
Loading

  1. always run test jobs when event_name != pull_request
  2. run test jobs when contains changes are not just docs.

@zirain zirain requested a review from a team as a code owner August 9, 2025 16:19
@codecov
Copy link

codecov bot commented Aug 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.07%. Comparing base (2488496) to head (deeffe1).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6748      +/-   ##
==========================================
+ Coverage   71.00%   71.07%   +0.07%     
==========================================
  Files         224      224              
  Lines       39621    39621              
==========================================
+ Hits        28132    28161      +29     
+ Misses       9828     9805      -23     
+ Partials     1661     1655       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain zirain changed the title ci: fix skipping on push revert: ci: skip test jobs when changes are not related Aug 9, 2025
@zirain zirain force-pushed the fix-ci branch 2 times, most recently from d3ce6fb to 1f3a875 Compare August 9, 2025 17:01
@zirain zirain changed the title revert: ci: skip test jobs when changes are not related ci: fix changes job Aug 9, 2025
@zirain
fix ci
deeffe1 
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
zirain commented Aug 9, 2025
View reviewed changes
.github/workflows/build_and_test.yaml
- 'release-notes/**'
- 'site/**'
run_test_workflow:
- "!?(site|release-notes)/**"
Copy link
Member Author

@zirain zirain Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@zirain zirain merged commit c3be64a into envoyproxy:main Aug 11, 2025
51 of 53 checks passed
@zirain zirain deleted the fix-ci branch August 11, 2025 08:11
@zirain
Copy link
Member Author

zirain commented Aug 11, 2025

A dependent job will be automatically skipped if its parent job is skipped.
So we should make changes always run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@shawnh2 shawnh2 shawnh2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zirain @zhaohuabing @shawnh2