chore: Don't render bootstrap local cluster if topologyInjector is disabled #6718

jukie · 2025-08-06T20:29:40Z

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

jukie · 2025-08-06T20:30:19Z

codecov · 2025-08-06T20:38:32Z

Codecov Report

❌ Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.99%. Comparing base (14a02b0) to head (ab60fa4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/infrastructure/host/proxy_infra.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6718      +/-   ##
==========================================
- Coverage   71.00%   70.99%   -0.01%     
==========================================
  Files         224      224              
  Lines       39606    39627      +21     
==========================================
+ Hits        28122    28133      +11     
- Misses       9824     9832       +8     
- Partials     1660     1662       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

jukie · 2025-08-06T21:57:03Z

/retest

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

internal/infrastructure/host/proxy_infra.go

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

internal/infrastructure/kubernetes/proxy/resource.go

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

arkodg

LGTM thanks

jukie · 2025-08-07T01:29:12Z

/retest

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

jukie · 2025-08-07T03:10:31Z

/retest

zirain · 2025-08-07T03:34:30Z

can we add a test case for this?

…sabled (envoyproxy#6718) * Consider topologyInjector when rendering bootstrap Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> * Add logic to provider Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

…sabled (envoyproxy#6718) * Consider topologyInjector when rendering bootstrap Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> * Add logic to provider Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com>

* docs: rm latest from install egctl docs (#6700) * we've removed the latest egctl artifacts Relates to #6551 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * chore: fix globalResources in GNM (#6701) Signed-off-by: zirain <zirain2009@gmail.com> * move ordering gateway-api resources to provider (#6695) Signed-off-by: zirain <zirain2009@gmail.com> * Rate Limiter: Enable rate limit for month and year (#6715) * update go control plane rate limiter version Signed-off-by: Pascal van Leeuwen <pascal@grove.city> * enable rate limit for month and year Signed-off-by: Pascal van Leeuwen <pascal@grove.city> * add attribution Signed-off-by: Pascal van Leeuwen <pascal@grove.city> * fix gen Signed-off-by: Pascal van Leeuwen <pascal@grove.city> * remove helm binaries Signed-off-by: Pascal van Leeuwen <pascal@grove.city> --------- Signed-off-by: Pascal van Leeuwen <pascal@grove.city> Co-authored-by: Rico Pahlisch <pahli88@googlemail.com> Signed-off-by: zirain <zirain2009@gmail.com> * docs: rm alpha alert for gateway namespace mode (#6709) Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * allow SNI and Cert SAN mismatch (#6719) Fixes: #6442 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * chore(charts): update metadata for gateway-crds-helm (#6725) * chore(charts): update metadata for gateway-crds-helm Signed-off-by: Maxime Brunet <max@brnt.mx> Signed-off-by: zirain <zirain2009@gmail.com> * chore: Don't render bootstrap local cluster if topologyInjector is disabled (#6718) * Consider topologyInjector when rendering bootstrap Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> * Add logic to provider Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com> * remove nit log when Backend API is disabled (#6708) * remove nit log when Backend API is disabled Signed-off-by: zirain <zirain2009@gmail.com> * fix: EnvoyProxy image with digest is rejected (#6720) * fix: EnvoyProxy image with digest is rejected Signed-off-by: zirain <zirain2009@gmail.com> * Revert "feat: add listener metadata (#6639)" (#6727) This reverts commit 20cb68b. Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: enhance extensibility index page (#6728) make it easier to pick the relevant extension type Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: add docs explaining graceful shutdown (#6729) * docs: add docs explaining graceful shutdown fixes: #2686 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: ClusterTrustBundle Support in BackendTLSPolicy (#6714) Signed-off-by: zirain <zirain2009@gmail.com> * chore: bump go 1.24.6 (#6732) Signed-off-by: zirain <zirain2009@gmail.com> * [release-1.5] release-notes for v1.5.0 (#6731) * [release-1.5] release-notes for v1.5.0 Signed-off-by: zirain <zirain2009@gmail.com> * update compatibility matrix Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> Signed-off-by: Pascal van Leeuwen <pascal@grove.city> Signed-off-by: Maxime Brunet <max@brnt.mx> Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: commoddity <47662958+commoddity@users.noreply.github.com> Co-authored-by: Rico Pahlisch <pahli88@googlemail.com> Co-authored-by: Maxime Brunet <max@brnt.mx> Co-authored-by: Isaac <10012479+jukie@users.noreply.github.com>

* docs: rm latest from install egctl docs (envoyproxy#6700) * we've removed the latest egctl artifacts Relates to envoyproxy#6551 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * chore: fix globalResources in GNM (envoyproxy#6701) Signed-off-by: zirain <zirain2009@gmail.com> * move ordering gateway-api resources to provider (envoyproxy#6695) Signed-off-by: zirain <zirain2009@gmail.com> * Rate Limiter: Enable rate limit for month and year (envoyproxy#6715) * update go control plane rate limiter version Signed-off-by: Pascal van Leeuwen <pascal@grove.city> * enable rate limit for month and year Signed-off-by: Pascal van Leeuwen <pascal@grove.city> * add attribution Signed-off-by: Pascal van Leeuwen <pascal@grove.city> * fix gen Signed-off-by: Pascal van Leeuwen <pascal@grove.city> * remove helm binaries Signed-off-by: Pascal van Leeuwen <pascal@grove.city> --------- Signed-off-by: Pascal van Leeuwen <pascal@grove.city> Co-authored-by: Rico Pahlisch <pahli88@googlemail.com> Signed-off-by: zirain <zirain2009@gmail.com> * docs: rm alpha alert for gateway namespace mode (envoyproxy#6709) Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * allow SNI and Cert SAN mismatch (envoyproxy#6719) Fixes: envoyproxy#6442 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * chore(charts): update metadata for gateway-crds-helm (envoyproxy#6725) * chore(charts): update metadata for gateway-crds-helm Signed-off-by: Maxime Brunet <max@brnt.mx> Signed-off-by: zirain <zirain2009@gmail.com> * chore: Don't render bootstrap local cluster if topologyInjector is disabled (envoyproxy#6718) * Consider topologyInjector when rendering bootstrap Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> * Add logic to provider Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com> * remove nit log when Backend API is disabled (envoyproxy#6708) * remove nit log when Backend API is disabled Signed-off-by: zirain <zirain2009@gmail.com> * fix: EnvoyProxy image with digest is rejected (envoyproxy#6720) * fix: EnvoyProxy image with digest is rejected Signed-off-by: zirain <zirain2009@gmail.com> * Revert "feat: add listener metadata (envoyproxy#6639)" (envoyproxy#6727) This reverts commit 20cb68b. Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: enhance extensibility index page (envoyproxy#6728) make it easier to pick the relevant extension type Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: add docs explaining graceful shutdown (envoyproxy#6729) * docs: add docs explaining graceful shutdown fixes: envoyproxy#2686 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: ClusterTrustBundle Support in BackendTLSPolicy (envoyproxy#6714) Signed-off-by: zirain <zirain2009@gmail.com> * chore: bump go 1.24.6 (envoyproxy#6732) Signed-off-by: zirain <zirain2009@gmail.com> * [release-1.5] release-notes for v1.5.0 (envoyproxy#6731) * [release-1.5] release-notes for v1.5.0 Signed-off-by: zirain <zirain2009@gmail.com> * update compatibility matrix Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> Signed-off-by: Pascal van Leeuwen <pascal@grove.city> Signed-off-by: Maxime Brunet <max@brnt.mx> Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: commoddity <47662958+commoddity@users.noreply.github.com> Co-authored-by: Rico Pahlisch <pahli88@googlemail.com> Co-authored-by: Maxime Brunet <max@brnt.mx> Co-authored-by: Isaac <10012479+jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com>

jukie and others added 2 commits August 6, 2025 14:29

Consider topologyInjector when rendering bootstrap

e9099b9

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

Merge branch 'main' into topology-injector-bootstrap

29222a2

arkodg added this to the v1.5.0 Release milestone Aug 6, 2025

Add logic to provider

1346d06

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

jukie changed the title ~~Consider topologyInjector when rendering bootstrap~~ chore: Don't render bootstrap local cluster if topologyInjector is disabled Aug 6, 2025

Handle nil gateway

b880b2a

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

jukie marked this pull request as ready for review August 6, 2025 22:19

jukie requested a review from a team as a code owner August 6, 2025 22:19

jukie requested review from a team and arkodg August 6, 2025 22:19

arkodg reviewed Aug 6, 2025

View reviewed changes

internal/infrastructure/host/proxy_infra.go Outdated Show resolved Hide resolved

add to helpers

a18f446

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

jukie requested a review from arkodg August 6, 2025 22:37

arkodg reviewed Aug 6, 2025

View reviewed changes

internal/infrastructure/kubernetes/proxy/resource.go Outdated Show resolved Hide resolved

jukie and others added 2 commits August 6, 2025 19:15

helper

407eddb

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

Merge branch 'main' into topology-injector-bootstrap

5354e4b

jukie requested a review from arkodg August 7, 2025 01:16

arkodg previously approved these changes Aug 7, 2025

View reviewed changes

arkodg requested review from a team August 7, 2025 01:25

nil handlers

ab60fa4

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

jukie dismissed arkodg’s stale review via ab60fa4 August 7, 2025 01:39

jukie requested a review from arkodg August 7, 2025 01:42

arkodg approved these changes Aug 7, 2025

View reviewed changes

arkodg requested review from a team August 7, 2025 14:38

zirain approved these changes Aug 7, 2025

View reviewed changes

arkodg merged commit 1c2bbb9 into envoyproxy:main Aug 7, 2025
46 of 51 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Don't render bootstrap local cluster if topologyInjector is disabled #6718

chore: Don't render bootstrap local cluster if topologyInjector is disabled #6718

Uh oh!

jukie commented Aug 6, 2025 •

edited

Loading

Uh oh!

jukie commented Aug 6, 2025

Uh oh!

codecov bot commented Aug 6, 2025 •

edited

Loading

Uh oh!

jukie commented Aug 6, 2025

Uh oh!

Uh oh!

Uh oh!

arkodg left a comment

Uh oh!

jukie commented Aug 7, 2025

Uh oh!

jukie commented Aug 7, 2025

Uh oh!

zirain commented Aug 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: Don't render bootstrap local cluster if topologyInjector is disabled #6718

chore: Don't render bootstrap local cluster if topologyInjector is disabled #6718

Uh oh!

Conversation

jukie commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jukie commented Aug 6, 2025

Uh oh!

codecov bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jukie commented Aug 6, 2025

Uh oh!

Uh oh!

Uh oh!

arkodg left a comment

Choose a reason for hiding this comment

Uh oh!

jukie commented Aug 7, 2025

Uh oh!

jukie commented Aug 7, 2025

Uh oh!

zirain commented Aug 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jukie commented Aug 6, 2025 •

edited

Loading

codecov bot commented Aug 6, 2025 •

edited

Loading