feat: Implement ZoneAware loadbalancing - Track Envoy pods via xDS (splitup #6482) #6597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6597 +/- ##
==========================================
+ Coverage 71.03% 71.10% +0.07%
==========================================
Files 225 225
Lines 39155 39264 +109
==========================================
+ Hits 27813 27918 +105
- Misses 9732 9734 +2
- Partials 1610 1612 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
a7d21dc to
cad1754
Compare
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Signed-off-by: Isaac <10012479+jukie@users.noreply.github.com>
Contributor
Author
|
/retest |
arkodg
reviewed
Jul 28, 2025
arkodg
reviewed
Jul 28, 2025
arkodg
reviewed
Jul 28, 2025
arkodg
reviewed
Jul 30, 2025
| func (t *Translator) ProcessGlobalResources(resources *resource.Resources, xdsIRs resource.XdsIRMap) error { | ||
| func (t *Translator) ProcessGlobalResources(resources *resource.Resources, xdsIRs resource.XdsIRMap, gateways []*GatewayContext) error { | ||
| // Add the ProxyServiceCluster information for each gateway to the IR map | ||
| for _, gateway := range gateways { |
Contributor
There was a problem hiding this comment.
this should ideally iterate over infraIR, right now we iterate through all gateways even for mergeGateways case, can be handled in a follow up
zirain
reviewed
Jul 30, 2025
| continue | ||
| } | ||
| match := true | ||
| for k, v := range labels { |
Member
There was a problem hiding this comment.
non-blocking, we can reuse somehting like
func isSelectorMatch(labelselector *metav1.LabelSelector, l map[string]string) (bool, error) {
selector, err := metav1.LabelSelectorAsSelector(labelselector)
if err != nil {
return false, fmt.Errorf("invalid label selector is generated: %w", err)
}
return selector.Matches(klabels.Set(l)), nil
}
Contributor
Author
|
/retest |
Contributor
Author
|
I can followup with the rest of the changes before the full release |
zirain
reviewed
Jul 30, 2025
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
zirain
reviewed
Jul 30, 2025
| accessLog: | ||
| json: | ||
| - path: /dev/stdout | ||
| globalResources: |
Contributor
Author
There was a problem hiding this comment.
I think that's expected here because the testdata input needs updated.
Contributor
Author
Member
There was a problem hiding this comment.
why globalResources not present in GatewayNamesapceMode?
arkodg
approved these changes
Jul 30, 2025
zirain
approved these changes
Jul 30, 2025
This was referenced Jul 30, 2025
This was referenced Aug 2, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: expose explicit configuration for Zone Aware Routing
What this PR does / why we need it:
This is the last PR related to splitting #6482 with the goal of exposing configuration for envoy localityLbConfig via BackendTrafficPolicy. Currently only ZoneAwareLbConfig is implemented but I'm planning on a followup to supported weightedLocalityLbConfig as well.
There's a lot of testdata changes here and I don't see a good way to split this up further without breaking e2e's but I've created draft PRs to try and make it easier to review.
Changes:
Which issue(s) this PR fixes:
Fixes #6025
Release Notes: Yes