Update mix.exs of guide to use :extra_applications #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

josevalim merged 1 commit into elixir-lang:master from harfangk:master

Jan 7, 2017

Contributor

harfangk commented Jan 7, 2017

Mix 1.4 introduced automatic inference of required applications from
dependencies list. Now Mix creates :extra_applications instead of
:applications by default in application configuration in mix.exs.
This commit updates the example mix.exs configurations in the guide to
reflect that change.

Signed-off-by: Bonghyun Kim bonghyun.d.kim@gmail.com


          Update mix.exs of guide to use :extra_applications

1677f84

Mix 1.4 introduced automatic inference of required applications from
dependencies list. Now Mix creates `:extra_applications` instead of
`:applications` by default in application configuration in `mix.exs`.
This commit updates the example `mix.exs` configurations in the guide to
reflect that change.

Signed-off-by: Bonghyun Kim <bonghyun.d.kim@gmail.com>

Contributor Author

harfangk commented Jan 7, 2017 •

edited

Loading

There are two other potential cases that I found.

https://hexdocs.pm/mix/1.4.0/Mix.Tasks.Compile.App.html#content

def application do
[mod: {MyApp, []},
env: [default: :value],
applications: [:crypto]]
end

http://elixir-lang.org/getting-started/erlang-libraries.html#the-crypto-module

def application do
[applications: [:crypto]]
end

I didn't include them in the PR because they are still correct usage, but would like to bring them to attention.

Member

josevalim commented Jan 7, 2017

Thank you, I will look into the other two!

josevalim merged commit bdc0d39 into elixir-lang:master

Member

josevalim commented Jan 7, 2017

❤️ 💚 💙 💛 💜

vladdu pushed a commit to vladdu/elixir-lang.github.com that referenced this pull request


          Update mix.exs of guide to use :extra_applications (elixir-lang#918)

e57a743

Mix 1.4 introduced automatic inference of required applications from
dependencies list. Now Mix creates `:extra_applications` instead of
`:applications` by default in application configuration in `mix.exs`.
This commit updates the example `mix.exs` configurations in the guide to
reflect that change.

Signed-off-by: Bonghyun Kim <bonghyun.d.kim@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet