Skip to content

[O11y][ActiveMQ] Remove forwarded tag from metrics data streams #7823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
harnish-crest-data merged 2 commits into from
Oct 9, 2023
Merged

[O11y][ActiveMQ] Remove forwarded tag from metrics data streams #7823

harnish-crest-data merged 2 commits into from
Oct 9, 2023

Conversation

@harnish-crest-data
Copy link
Contributor

@harnish-crest-data harnish-crest-data commented Sep 14, 2023 •
edited
Loading

  • Bug

What does this PR do?

  • This PR remove forwarded tag from the metricbeat-based data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@harnish-crest-data harnish-crest-data added Integration:activemq ActiveMQ bugfix Pull request that fixes a bug issue labels Sep 14, 2023
@harnish-crest-data harnish-crest-data self-assigned this Sep 14, 2023
@harnish-crest-data harnish-crest-data marked this pull request as ready for review September 14, 2023 12:21
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner September 14, 2023 12:21
@harnish-crest-data harnish-crest-data mentioned this pull request Sep 14, 2023
Closed
7 tasks
@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-14T12:22:10.184+0000

  • Duration: 19 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 95.833% (23/24) 👍 70.833
Lines 85.321% (93/109) 👎 -14.679
Conditionals 100.0% (0/0) 💚

ishleenk17
ishleenk17 reviewed Sep 20, 2023
View reviewed changes
ali786XI
ali786XI approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ishleenk17
ishleenk17 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@harnish-crest-data harnish-crest-data merged commit 28bb6da into elastic:main Oct 9, 2023
@elasticmachine
Copy link

elasticmachine commented Oct 9, 2023

Package activemq - 0.13.1 containing this change is available at https://epr.elastic.co/search?package=activemq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

+1 more reviewer

@ali786XI ali786XI ali786XI approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harnish-crest-data harnish-crest-data

Labels

bugfix Pull request that fixes a bug issue Integration:activemq ActiveMQ

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harnish-crest-data @elasticmachine @ishleenk17 @ali786XI