Skip to content

cisco_ise: convert dashboard visualisations to lens #6799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
efd6 merged 2 commits into from
Jul 5, 2023
Merged

cisco_ise: convert dashboard visualisations to lens #6799

efd6 merged 2 commits into from
Jul 5, 2023

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Jul 4, 2023

What does this PR do?

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jul 4, 2023
@efd6 efd6 force-pushed the 6787-cisco_ise branch from 8ef1387 to 4d6591f Compare July 4, 2023 07:48
@efd6 efd6 mentioned this pull request Jul 4, 2023
Closed
36 tasks
@elasticmachine
Copy link

elasticmachine commented Jul 4, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-05T08:48:50.455+0000

  • Duration: 15 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 4, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (17/17) 💚 2.842
Classes 100.0% (17/17) 💚 2.842
Methods 100.0% (176/176) 💚 7.852
Lines 99.003% (4566/4612) 👍 7.188
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review July 4, 2023 08:07
@efd6 efd6 requested a review from a team as a code owner July 4, 2023 08:07
@elasticmachine
Copy link

elasticmachine commented Jul 4, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

P1llus
P1llus approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nit

packages/cisco_ise/manifest.yml Outdated
Copy link
Member

@P1llus P1llus Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be 8.7.1

@efd6 efd6 force-pushed the 6787-cisco_ise branch from 4d6591f to f7739a7 Compare July 5, 2023 08:48
@efd6 efd6 merged commit 19fd514 into elastic:main Jul 5, 2023
@elasticmachine
Copy link

elasticmachine commented Jul 5, 2023

Package cisco_ise - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=cisco_ise

@efd6 efd6 deleted the 6787-cisco_ise branch February 5, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P1llus P1llus P1llus approved these changes

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:cisco_ise Cisco ISE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6 @elasticmachine @P1llus