Skip to content

cisco_ise: map cisco_ise.log.avpair.task_id as keyword #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
efd6 merged 1 commit into from
Sep 13, 2022
Merged

cisco_ise: map cisco_ise.log.avpair.task_id as keyword #4087

efd6 merged 1 commit into from
Sep 13, 2022

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Aug 29, 2022

What does this PR do?

In most documented cases cisco_ise.log.avpair.task_id appears to be a decimal
numeric value. However, in the wild hex, numerical and UUID values appear to
exist so map as a keyword.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Aug 29, 2022
@efd6
cisco_ise: map cisco_ise.log.avpair.task_id as keyword
b5166b5 
In most documented cases cisco_ise.log.avpair.task_id appears to be a decimal
numeric value. However, in the wild hex, numerical and UUID values appear to
exist so map as a keyword.
@elasticmachine
Copy link

elasticmachine commented Aug 29, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-13T01:08:13.926+0000

  • Duration: 14 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 90
Skipped 0
Total 90

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 29, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (17/17) 💚 2.537
Classes 100.0% (17/17) 💚 2.537
Methods 100.0% (181/181) 💚 9.77
Lines 99.835% (3019/3024) 👍 8.934
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review August 29, 2022 04:51
@efd6 efd6 requested a review from a team as a code owner August 29, 2022 04:51
@elasticmachine
Copy link

elasticmachine commented Aug 29, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@Bernhard-Fluehmann
Copy link
Contributor

Bernhard-Fluehmann commented Sep 2, 2022

Thanks for fixing. I have manually changed the processor and mapping as well and it works fine so far.

@efd6
Copy link
Contributor Author

efd6 commented Sep 13, 2022

/test

@efd6 efd6 merged commit b90cb19 into elastic:main Sep 13, 2022
@andrewkroh andrewkroh mentioned this pull request Sep 19, 2022
Merged
@efd6 efd6 deleted the 4075-cisco_ise branch February 5, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:cisco_ise Cisco ISE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cisco_ise wrong field-type of field cisco_ise.log.avpair.task_id

4 participants

@efd6 @elasticmachine @Bernhard-Fluehmann @andrewkroh