Skip to content

Update ECS to 8.4.0 Part 4 #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leehinman merged 21 commits into from
Jul 29, 2022
Merged

Update ECS to 8.4.0 Part 4 #3865

leehinman merged 21 commits into from
Jul 29, 2022

Conversation

@leehinman
Copy link
Contributor

@leehinman leehinman commented Jul 27, 2022

  • cylance
  • f5
  • fim
  • fireeye
  • fortinet
  • gcp
  • gcp_pubsub
  • github
  • google_workspace
  • hashicorp_vault

@leehinman leehinman changed the title Update ECS to 8.4.0 Update ECS to 8.4.0 Part 4 Jul 27, 2022
@elasticmachine
Copy link

elasticmachine commented Jul 27, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-29T19:01:06.622+0000

  • Duration: 24 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 204
Skipped 0
Total 204

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (23/23) 💚
Files 100.0% (28/28) 💚 2.868
Classes 100.0% (28/28) 💚 2.868
Methods 94.627% (317/335) 👍 5.376
Lines 92.493% (5298/5728) 👍 1.891
Conditionals 100.0% (0/0) 💚

@leehinman leehinman marked this pull request as ready for review July 28, 2022 18:08
@leehinman leehinman requested review from a team as code owners July 28, 2022 18:08
@elasticmachine
Copy link

elasticmachine commented Jul 28, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

kcreddy
kcreddy requested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes (mainly pipeline test files) which could be added. Rest LGTM

packages/gcp_pubsub/manifest.yml Outdated
Copy link
Contributor

@kcreddy kcreddy Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably generic datastream pipeline inside gcp_pub needs ECS version update

@taylor-swanson
Copy link
Contributor

taylor-swanson commented Jul 28, 2022 •
edited
Loading

I don't think @elastic/obs-cloud-monitoring should be listed as a code owner here, all of these integrations are owned by @elastic/security-external-integrations?

EDIT: Never mind I suppose, CODEOWNERS lists both teams, but Github is only lists @elastic/obs-cloud-monitoring as the codeowner for the PR.

taylor-swanson
taylor-swanson approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leehinman added 16 commits July 29, 2022 13:59
@leehinman
Update ECS version for cylance
e007723 
ECS version updated to 8.4.0
@leehinman
Update ECS version for f5
6081609 
ECS version updated to 8.4.0
@leehinman
Update ECS version for fim
2e2bb09 
ECS version updated to 8.4.0
@leehinman
Update ECS version for fireeye
cfc1c70 
ECS version updated to 8.4.0
@leehinman
Update ECS version for fortinet
ba3d13b 
ECS version updated to 8.4.0
@leehinman
Update ECS version for gcp
88ee5d5 
ECS version updated to 8.4.0
@leehinman
Update ECS version for gcp_pubsub
0aab6d6 
ECS version updated to 8.4.0
@leehinman
Update ECS version for github
63976ed 
ECS version updated to 8.4.0
@leehinman
Update ECS version for google_workspace
0f82ab1 
ECS version updated to 8.4.0
@leehinman
Update ECS version for hashicorp_vault
087d4fd 
ECS version updated to 8.4.0
@leehinman
Updated Changelog, Manifest and pipeline tests for cylance
c21bf68
@leehinman
Updated Changelog, Manifest and pipeline tests for f5
c16dbf1
@leehinman
Updated Changelog, Manifest and pipeline tests for fim
71bf845
@leehinman
Updated Changelog, Manifest and pipeline tests for fireeye
6041312
@leehinman
Updated Changelog, Manifest and pipeline tests for fortinet
fbeadc3
@leehinman
Updated Changelog, Manifest and pipeline tests for gcp
96b543b
@leehinman leehinman merged commit 90ef473 into elastic:main Jul 29, 2022
@andrewkroh andrewkroh mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

@taylor-swanson taylor-swanson taylor-swanson approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leehinman @elasticmachine @taylor-swanson @kcreddy