Skip to content

[etcd] Add metrics dashboard #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mtojek merged 6 commits into from
Dec 21, 2021
Merged

[etcd] Add metrics dashboard #2336

mtojek merged 6 commits into from
Dec 21, 2021

Conversation

@gpop63
Copy link
Contributor

@gpop63 gpop63 commented Dec 13, 2021 •
edited
Loading

What does this PR do?

Adds a dashboard for etcd metrics.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

metrics-overview

@elasticmachine
Copy link

elasticmachine commented Dec 13, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-15T23:04:25.000+0000

  • Duration: 15 min 11 sec

  • Commit: f228c5d

Test stats 🧪

Test Results
Failed 0
Passed 20
Skipped 0
Total 20

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@gpop63 gpop63 changed the title Etcd dashboard [etcd] Add metrics dashboard Dec 13, 2021
mtojek
mtojek reviewed Dec 14, 2021
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on my side:

  • Please include a host selector
  • Please adjust the snapshot:
    • Use any browser extension to take the screenshot of the entire page
    • Shows collected data, not flat lines
  • You may want to add more colours to graphs (red - bad, green - good, blue - neutral)

I was referring mainly to the Apache dashboard.

@mtojek mtojek added the Team:Integrations Label for the Integrations team label Dec 14, 2021
@mtojek mtojek marked this pull request as ready for review December 21, 2021 10:24
@elasticmachine
Copy link

elasticmachine commented Dec 21, 2021

Pinging @elastic/integrations (Team:Integrations)

@mtojek mtojek self-requested a review December 21, 2021 10:25
mtojek
mtojek approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this in, we can always iterate on this one later (cc @akshay-saraswat if you see more improvements needed).

@mtojek mtojek merged commit 7e99230 into elastic:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshay-saraswat akshay-saraswat Awaiting requested review from akshay-saraswat

1 more reviewer

@mtojek mtojek mtojek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gpop63 @elasticmachine @mtojek