Left minor comments in-line. And a final suggestion to potentially add a description of what a bucket is (or a link to the definition to OpenAI web site). Other than that looks good.

Thanks.

And a final suggestion to potentially add a description of what a bucket is (or a link to the definition to OpenAI web site)

So, if you look at L52 of the docs, I have mentioned it there:

• Controls the time-based aggregation of metrics (e.g., bucket_width)

I have linked it as well.

The link does show the definition for the field:

Width of each time bucket in response. Currently 1m, 1h and 1d are supported, default to 1d.

There's nothing more on bucket width in OpenAI's website.

So, if you look at L52 of the docs, I have mentioned it there:

• Controls the time-based aggregation of metrics (e.g., bucket_width)

I meant add an explanation (or link) to the definition of bucket, not only bucket width. If you are introducing the concept of a bucket then we should be explaining what it actually is. And then we can talk about bucket width

So, if you look at L52 of the docs, I have mentioned it there:

• Controls the time-based aggregation of metrics (e.g., bucket_width)

I meant add an explanation (or link) to the definition of bucket, not only bucket width. If you are introducing the concept of a bucket then we should be explaining what it actually is. And then we can talk about bucket width

Done!

💚 Build Succeeded

• Buildkite Build
• Commit: 218b433

History

• 💚 Build #22798 succeeded b1552ef
• 💚 Build #22794 succeeded 89e2126
• 💚 Build #22781 succeeded 0c24d45
• 💚 Build #22735 succeeded f507ad2
• 💚 Build #22574 succeeded e2631f1
• 💚 Build #22573 succeeded e4a4c76

cc @shmsr

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Package openai - 0.3.0 containing this change is available at https://epr.elastic.co/package/openai/0.3.0/