-
Notifications
You must be signed in to change notification settings - Fork 519
[jamf_pro] Inventory date formatting for filter #12333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
|
/test |
💚 Build Succeeded
History
|
|
kcreddy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Package jamf_pro - 0.2.2 containing this change is available at https://epr.elastic.co/package/jamf_pro/0.2.2/ |
Ensure that `reportDate` values with less than 3 digits of a fractional second will be padded with zeros to 3 digits before they are used in the `filter` parameter. Avoids HTTP 400 responses saying: > Date [2025-01-08T10:50:26.6Z] does not match any of supported formats: > yyyy-MM-ddTHH:mm:ss.SSSZ, yyyy-MM-ddTHH:mm:ss.SSZ, > yyyy-MM-ddTHH:mm:ssZ, yyyy-MM-dd*, yyyy-MM-dd, yyyy-MM*, yyyy* Also improves the CEL error handling by returning a single event outside of an array (which will be logged). This has been manually tested against the live API.
Ensure that `reportDate` values with less than 3 digits of a fractional second will be padded with zeros to 3 digits before they are used in the `filter` parameter. Avoids HTTP 400 responses saying: > Date [2025-01-08T10:50:26.6Z] does not match any of supported formats: > yyyy-MM-ddTHH:mm:ss.SSSZ, yyyy-MM-ddTHH:mm:ss.SSZ, > yyyy-MM-ddTHH:mm:ssZ, yyyy-MM-dd*, yyyy-MM-dd, yyyy-MM*, yyyy* Also improves the CEL error handling by returning a single event outside of an array (which will be logged). This has been manually tested against the live API.




Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
The system test has been updated to demonstrate the new functionality.
Related issues