-
Notifications
You must be signed in to change notification settings - Fork 519
[Nginx Otel] Fix body structured field in dashboards #11625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nginx Otel] Fix body structured field in dashboards #11625
Conversation
ChrsMark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| [here](https://github.com/kubernetes/ingress-nginx/blob/nginx-0.30.0/docs/user-guide/nginx-configuration/log-format.md). | ||
|
|
||
| **EDOT collector supported versions:** 8.16.0-SNAPSHOT | ||
| **EDOT collector supported versions:** 8.16.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are mentioning collector version as 8.16 and kibana.version in manifest as 9.0.0
Do we plan to support this from 8.16.0 onwards or 9.0.0 onwards ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ishleenk17, just changed the Kibana version to 8.16.0 so its aligned with the EDOT collector one: faa1df7
Do we plan to support this from 8.16.0 onwards or 9.0.0 onwards ?
8.16.0 but the integration is on tech preview, there might be some breaking changes depending on the upstream Semantic convention decisions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking changes might always be part of these OTEL Integrations as they would be dependent on upstream changes
💚 Build Succeeded
History
|
|
| [here](https://github.com/kubernetes/ingress-nginx/blob/nginx-0.30.0/docs/user-guide/nginx-configuration/log-format.md). | ||
|
|
||
| **EDOT collector supported versions:** 8.16.0-SNAPSHOT | ||
| **EDOT collector supported versions:** 8.16.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking changes might always be part of these OTEL Integrations as they would be dependent on upstream changes
|
Package nginx_ingress_controller_otel - 0.0.2 containing this change is available at https://epr.elastic.co/package/nginx_ingress_controller_otel/0.0.2/ |
…1625) * fix: use body_structure for dashboards * chore: new version changelog * fix: esql dashboard based in body.structured * chore: fix changelog type
…astic#11625) * fix: use body_structure for dashboards * chore: new version changelog * fix: esql dashboard based in body.structured * chore: fix changelog type
…1625) * fix: use body_structure for dashboards * chore: new version changelog * fix: esql dashboard based in body.structured * chore: fix changelog type
…astic#11625) * fix: use body_structure for dashboards * chore: new version changelog * fix: esql dashboard based in body.structured * chore: fix changelog type




Proposed commit message
Use
body.structurednamespace instead ofattributesfor dashboards.In addition, some fields for the
nginx_ingress_controller.errorevent has been mapped to the proposed semantic convetnion version: open-telemetry/semantic-conventions#982 (without theerrorprefix)Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots