Skip to content

Conversation

@rogercoll
Copy link
Contributor

@rogercoll rogercoll commented Nov 4, 2024

Proposed commit message

Use body.structured namespace instead of attributes for dashboards.

In addition, some fields for the nginx_ingress_controller.error event has been mapped to the proposed semantic convetnion version: open-telemetry/semantic-conventions#982 (without the error prefix)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@rogercoll rogercoll requested a review from a team as a code owner November 4, 2024 08:33
@rogercoll rogercoll requested a review from ChrsMark November 4, 2024 08:39
@andrewkroh andrewkroh added enhancement New feature or request Integration:nginx_ingress_controller_otel Nginx Ingress Controller OpenTelemetry Logs Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Nov 4, 2024
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rogercoll rogercoll enabled auto-merge (squash) November 4, 2024 10:54
@rogercoll rogercoll requested a review from ishleenk17 November 6, 2024 10:25
[here](https://github.com/kubernetes/ingress-nginx/blob/nginx-0.30.0/docs/user-guide/nginx-configuration/log-format.md).

**EDOT collector supported versions:** 8.16.0-SNAPSHOT
**EDOT collector supported versions:** 8.16.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are mentioning collector version as 8.16 and kibana.version in manifest as 9.0.0
Do we plan to support this from 8.16.0 onwards or 9.0.0 onwards ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ishleenk17, just changed the Kibana version to 8.16.0 so its aligned with the EDOT collector one: faa1df7

Do we plan to support this from 8.16.0 onwards or 9.0.0 onwards ?

8.16.0 but the integration is on tech preview, there might be some breaking changes depending on the upstream Semantic convention decisions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes might always be part of these OTEL Integrations as they would be dependent on upstream changes

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube
Copy link

@rogercoll rogercoll requested a review from ishleenk17 November 19, 2024 09:45
[here](https://github.com/kubernetes/ingress-nginx/blob/nginx-0.30.0/docs/user-guide/nginx-configuration/log-format.md).

**EDOT collector supported versions:** 8.16.0-SNAPSHOT
**EDOT collector supported versions:** 8.16.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes might always be part of these OTEL Integrations as they would be dependent on upstream changes

@rogercoll rogercoll merged commit b1dc545 into elastic:main Nov 20, 2024
5 checks passed
@rogercoll rogercoll deleted the fix_body_structured_dashboards branch November 20, 2024 07:43
@elastic-vault-github-plugin-prod

Package nginx_ingress_controller_otel - 0.0.2 containing this change is available at https://epr.elastic.co/package/nginx_ingress_controller_otel/0.0.2/

qcorporation pushed a commit that referenced this pull request Feb 3, 2025
…1625)

* fix: use body_structure for dashboards

* chore: new version changelog

* fix: esql dashboard based in body.structured

* chore: fix changelog type
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…astic#11625)

* fix: use body_structure for dashboards

* chore: new version changelog

* fix: esql dashboard based in body.structured

* chore: fix changelog type
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
…1625)

* fix: use body_structure for dashboards

* chore: new version changelog

* fix: esql dashboard based in body.structured

* chore: fix changelog type
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…astic#11625)

* fix: use body_structure for dashboards

* chore: new version changelog

* fix: esql dashboard based in body.structured

* chore: fix changelog type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:nginx_ingress_controller_otel Nginx Ingress Controller OpenTelemetry Logs Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants