Skip to content

Conversation

@aleksmaus
Copy link
Contributor

Proposed commit message

Fix multiple pipeline processing issues, based on the users reported issues:

  • Fix error: field [_ingest._value] does not contain value_split [=]
  • Fix error: [grok_message_details: For input string: "05:00:02.595", Cannot invoke "java.lang.CharSequence.length()" because "this.wrapped" is null]
  • Fix error: 13.33.14.64, AdminSession=ProfilerSession' is not an IP string literal.

(!) The first fix requires changes in the elastic-package to handle validation on the field with enabled:false

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@aleksmaus aleksmaus added Integration:cisco_ise Cisco ISE bugfix Pull request that fixes a bug issue labels Nov 1, 2024
@aleksmaus aleksmaus self-assigned this Nov 1, 2024
@aleksmaus aleksmaus requested a review from a team as a code owner November 1, 2024 22:39
@andrewkroh andrewkroh added the Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] label Nov 2, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@aleksmaus
Copy link
Contributor Author

This PR will continue failing until the elastic-package is updated elastic/elastic-package#2192

@aleksmaus
Copy link
Contributor Author

/test

@aleksmaus aleksmaus requested a review from a team as a code owner November 11, 2024 15:37
@aleksmaus
Copy link
Contributor Author

/test

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 11, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@aleksmaus
Copy link
Contributor Author

/test

the two integrations tests not related to this PR changes keep failing

dependency failed to start: container elastic-package-stack-elastic-agent-1 exited (1)
--
  | Error: booting up the stack failed: running docker-compose failed: running command failed: running Docker Compose up command failed: exit status 1: Container elastic-package-stack-package-registry-1  Running
Screenshot 2024-11-11 at 3 03 21 PM

go.mod Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for this release to succeed. It was unexpectedly tagged, and hasn't been properly created yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating in #11709

@aleksmaus
Copy link
Contributor Author

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @aleksmaus

@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@aleksmaus aleksmaus merged commit c55e51d into elastic:main Nov 13, 2024
4 of 5 checks passed
@elastic-vault-github-plugin-prod

Package cisco_ise - 1.24.1 containing this change is available at https://epr.elastic.co/package/cisco_ise/1.24.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_ise Cisco ISE Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants