[Transform] Create upgrade mode #117858
Merged
[Transform] Create upgrade mode #117858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent writes to the Transform system index while it is being reindexed during upgrade. - Add a new REST API, `_transform/set_upgrade_mode`, similar to `_ml`, which will enable via `?enabled` or disable (when omitted). - Add a new Transport action, enabling or disabling upgrade mode. When enabled, all Transforms will abort and move into the `waiting` state, preventing Transforms from running and writing to the system index. - Hook into the System Index upgrade action, calling the new Transform action to set and unset upgrade mode.
Collaborator
|
Hi @prwhelan, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
approved these changes
Dec 4, 2024
x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/Transform.java
Outdated
Show resolved
Hide resolved
| ) { | ||
| var wasAlreadyInUpgradeMode = (boolean) preUpgradeMetadata.getOrDefault("already_in_upgrade_mode", false); | ||
| if (wasAlreadyInUpgradeMode) { | ||
| // Transform was already in upgrade mode before system indices upgrade started - we shouldn't disable it |
…transform/Transform.java Co-authored-by: David Kyle <david.kyle@elastic.co>
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine update branch |
Collaborator
💚 Backport successful
|
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Dec 30, 2024
Prevent writes to the Transform system index while it is being reindexed during upgrade. - Add a new REST API, `_transform/set_upgrade_mode`, similar to `_ml`, which will enable via `?enabled` or disable (when omitted). - Add a new Transport action, enabling or disabling upgrade mode. When enabled, all Transforms will abort and move into the `waiting` state, preventing Transforms from running and writing to the system index. - Hook into the System Index upgrade action, calling the new Transform action to set and unset upgrade mode. Co-authored-by: David Kyle <david.kyle@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 30, 2024
Prevent writes to the Transform system index while it is being reindexed during upgrade. - Add a new REST API, `_transform/set_upgrade_mode`, similar to `_ml`, which will enable via `?enabled` or disable (when omitted). - Add a new Transport action, enabling or disabling upgrade mode. When enabled, all Transforms will abort and move into the `waiting` state, preventing Transforms from running and writing to the system index. - Hook into the System Index upgrade action, calling the new Transform action to set and unset upgrade mode. Co-authored-by: David Kyle <david.kyle@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent writes to the Transform system index while it is being reindexed during upgrade.
_transform/set_upgrade_mode, similar to_ml, which will enable via?enabledor disable (when omitted).waitingstate, preventing Transforms from running and writing to the system index.