Adding chunking settings to IbmWatsonxService #114914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@elasticmachine merge upstream |
Collaborator
|
Hi @dan-rubinstein, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Collaborator
💚 Backport successful
|
dan-rubinstein
added a commit
to dan-rubinstein/elasticsearch
that referenced
this pull request
Nov 21, 2024
* Adding chunking settings to IbmWatsonxService * Removing feature flag * Update docs/changelog/114914.yaml --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 21, 2024
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Nov 22, 2024
* Adding chunking settings to IbmWatsonxService * Removing feature flag * Update docs/changelog/114914.yaml --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
* Adding chunking settings to IbmWatsonxService * Removing feature flag * Update docs/changelog/114914.yaml --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #117188
Description
This change introduces:
Note: Chunking currently only runs when large documents are ingested to an index with an inference field.
Testing
chunking_settingsprovided generates a model with default chunking settings (keeps existing sentence based chunking strategy with default configurations).chunking_settingsfor a word based chunking strategy provided generates a model that uses the word based chunking strategy.chunking_settingsfor a sentence based chunking strategy provided generates a model that uses the sentence based chunking strategy.