Ensure correct execution order for user-provided delegates #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary change here is to ensure that we register EDOT defaults before user-provided configuration delegates and add the OTLP exporter after them. Introduces `BuilderContext` and `BuilderOptions` to support this. Other changes - Upgrade OpenTelemetry packages in sample apps to version 1.13.x across project files. - Enhance logging with new `DeferredLogger` and update `FileLogger` for better log handling. - Improve documentation and configuration patterns in builder extension files.
src/Elastic.OpenTelemetry.Core/Extensions/OpenTelemetryLoggerOptionsExtensions.cs
Show resolved
Hide resolved
2cf6e89 to
c910b03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change here is to ensure that we register EDOT defaults before user-provided configuration delegates and add the OTLP exporter after them. Introduces
BuilderContextandBuilderOptionsto support this.Other changes
DeferredLoggerand updateFileLoggerfor better log handling.Closes #311
Closes #319