Treat EventLevel.Verbose as debug log level #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using SDK diagnostics, the lowest supported log level for OTEL_LOG_LEVEL is 'debug'. To align with this, we emit verbose logs captured by the EventListener under debug. This change also updates the logger messages to not use trace level and prefer debug in those cases. This make diagnostics and support easier as we only need to instruct the customer to use the levels as supported upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SDK diagnostics, the lowest supported log level for OTEL_LOG_LEVEL is 'debug'. To align with this, we emit verbose logs captured by the EventListener under debug.
This change also updates the logger messages to not use trace level and prefer debug in those cases. This make diagnostics and support easier as we only need to instruct the customer to use the levels as supported upstream.