Better warning when in Fortran a program unit or routine is not closed #10607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analogues to doxygen#10587 we also need warnings for program units and as it can be nested we need a stack to record what is still open.
doxygen
reviewed
Feb 16, 2024
src/fortranscanner.l
Outdated
| QCString blockString; | ||
| int blockLineNr = -1; | ||
| }; | ||
| std::stack<blockState> g_blockStack; |
There was a problem hiding this comment.
Global variables will create data races and crashes when using multiple threads (e.g. NUM_PROC_THREADS!=1).
Assuming this state is per file, you need to put this variable in fortranscannerYY_state and access it via yyextra.
There was a problem hiding this comment.
I think the commit e87e708 from February 17, 2024 fixes this problem.
After review, global variables are not thread safe use thread safe construct
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogues to #10587 we also need warnings for program units and as it can be nested we need a stack to record what is still open.
Example: example.tar.gz
(Found by Fossies for the rlab package)