Replace use of ArrayList with List<T> in BamlMapTable for performance #9967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himgoyalmicro
previously approved these changes
Mar 24, 2025
|
@h3xds1nz this PR is good to be merged. Can you please resolve the merge conflicts? |
ee35295 to
13de797
Compare
|
@himgoyalmicro Yeyyyy :) Done |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9967 +/- ##
===================================================
- Coverage 11.45872% 11.07036% -0.38836%
===================================================
Files 3214 3352 +138
Lines 648458 668000 +19542
Branches 71511 74980 +3469
===================================================
- Hits 74305 73950 -355
- Misses 572989 592890 +19901
+ Partials 1164 1160 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
himgoyalmicro
approved these changes
Mar 24, 2025
|
Thank you, @h3xds1nz, for your consistent and valuable contributions. 😄 |
|
@himgoyalmicro Thank you for reviewing :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces 4x
ArrayListcollections withList<T>for improved performance and increased type safety.I've also introduced
initsetters for the respective properties so they can be used as part of theCloneoperation and the underlying fields can be converted toreadonly. Rest are just NULL check removals coming from theascasting pattern or simply redundant as the values in the lists are always from freshly initialized types, no NULLs are inserted.Sample benchmark showing difference between
ArrayListandList<T>with reference type can be found f.e. in #9432.Customer Impact
Improved performance, cleaner codebase for developers.
Regression
No.
Testing
Local build.
Risk
Low, just type swaps.
Microsoft Reviewers: Open in CodeFlow