Optimize parsing and serialization of generic type names in Xaml, decrease allocs #9940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h3xds1nz this PR is good to be merged. Can you please resolve the merge conflicts. |
0742fdf to
98b33ee
Compare
|
@himgoyalmicro Done :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9940 +/- ##
===================================================
- Coverage 11.45872% 11.23175% -0.22697%
===================================================
Files 3214 3352 +138
Lines 648458 668017 +19559
Branches 71511 74983 +3472
===================================================
+ Hits 74305 75030 +725
- Misses 572989 591824 +18835
+ Partials 1164 1163 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
himgoyalmicro
approved these changes
Mar 24, 2025
|
Thank you, @h3xds1nz, for your consistent and valuable contributions. |
|
@himgoyalmicro Thank you for reviewing :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimizes retrievals of subscripts/type names from generic types and also its serialization back to string.
This is meant to be very straightforward (as the main modification is done to
GenericTypeNameScanner.StripSubscriptand other modifications are just to comfort the change), so a lot of strings were kept, that's not an oversight. I believe those changes should be done in small batches.Customer Impact
Improved performance, decreased allocations.
Regression
No.
Testing
Local build, unit tests.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow