Fixed elevation border brush for Light and Dark theme #10567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10567 +/- ##
===================================================
- Coverage 11.54183% 11.41184% -0.12999%
===================================================
Files 3214 3214
Lines 648502 648502
Branches 71510 71510
===================================================
- Hits 74849 74006 -843
- Misses 572401 573335 +934
+ Partials 1252 1161 -91
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
siagupta0202
approved these changes
Mar 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10569
Description
Since #10502 is fixed now, I have raised this PR to fix the elevation brushes for Light and Dark themes. Elevation brushes use RelativeTransform alongwith an Absolute mode LinearGradientBrush.
Customer Impact
Fixes Fluent theme resources
Regression
No
Testing
Local testing
Risk
Minimal
Microsoft Reviewers: Open in CodeFlow