Cleanup dead code in dotnet test #49952
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes dead code from the dotnet test command by eliminating the unused Architecture parameter from the TestOptions record and updating related method signatures accordingly.
- Removes the
Architectureparameter from theTestOptionsrecord constructor - Updates the
GetTestOptionsmethod to no longer accept or use theParseResultparameter - Simplifies the method call in
PrepareEnvironmentto match the updated signature
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/Test/TestingPlatformCommand.cs | Updates method signature and call to remove unused ParseResult parameter |
| src/Cli/dotnet/Commands/Test/Options.cs | Removes Architecture parameter from TestOptions record |
Comments suppressed due to low confidence (1)
src/Cli/dotnet/Commands/Test/TestingPlatformCommand.cs:95
- The removal of the Architecture parameter from TestOptions should include test updates to verify the change doesn't break existing functionality. Consider adding or updating tests to ensure the TestOptions record works correctly with only the remaining parameters.
testOptions = GetTestOptions(filterModeEnabled, isHelp: ContainsHelpOption(arguments));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.