NuGet's dotnet cli commands should use common interactive option #49944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the NuGet command integration to use the dotnet CLI's common interactive option instead of reimplementing its own logic. The change ensures consistency with the CLI's built-in CI detection and output redirection handling.
Key Changes
- Updates NuGet command registration to pass the common interactive option
- Removes potential duplication of interactive option logic between NuGet and dotnet CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dotnet CLI has a default value factory for the
--interactivecommand that detects CI, as well as redirected output. It's better for NuGet to reuse it, rather than reimplement it and need to keep it updated in case the sdk changes it.