Skip to content

Update named pipe for dotnet test #49936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2025
Merged

Update named pipe for dotnet test #49936

merged 3 commits into from
Jul 28, 2025

Conversation

Youssef1313
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings July 25, 2025 10:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the named pipe implementation for dotnet test to use the LocalApplicationData folder instead of the system temporary directory for storing pipe-related files.

Key Changes

  • Changed the directory location for named pipe files from the system temp path to the user's LocalApplicationData folder

@Youssef1313 Youssef1313 enabled auto-merge (squash) July 25, 2025 10:09
@Youssef1313
Copy link
Member Author

This is failing on macOS.

builder.Append($" {CliConstants.ServerOptionKey} {CliConstants.ServerOptionValue} {CliConstants.DotNetTestPipeOptionKey} {_pipeNameDescription.Name}");

@mariam-abdulla Are we missing some escaping here? Probably just need to wrap the pipe name between double quotes?

@Youssef1313 Youssef1313 merged commit 4f506a7 into main Jul 28, 2025
27 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/named-pipe branch July 28, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants