Send Ctrl+C to launched process before killing it on Windows #49847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, @@tmat. |
This was referenced Jul 18, 2025
1fe04bf to
4d7541d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements graceful termination of dotnet-watch processes on Windows by enabling Ctrl+C signal handling. The primary goal is to allow Windows processes launched by dotnet-watch to receive and handle Ctrl+C events properly before being forcefully terminated.
Key changes:
- Added Windows-specific Ctrl+C event handling using Windows API calls
- Modified process creation to use CREATE_NEW_PROCESS_GROUP flag for user applications on Windows
- Updated timeout values to allow graceful shutdown instead of immediate termination
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/BuiltInTools/dotnet-watch/Utilities/ProcessUtilities.cs |
New utility class with Windows API interop for Ctrl+C handling and signal management |
src/BuiltInTools/dotnet-watch/Process/ProcessRunner.cs |
Modified process termination logic to support graceful shutdown with Ctrl+C on Windows |
src/BuiltInTools/dotnet-watch/Process/ProcessSpec.cs |
Added IsUserApplication property to distinguish between user apps and helper processes |
test/dotnet-watch.Tests/TestUtilities/WatchableApp.cs |
Updated test utilities to enable Windows Ctrl+C handling and increased timeout values |
test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs |
Added Windows-specific test for graceful termination and updated existing tests |
src/BuiltInTools/DotNetDeltaApplier/StartupHook.cs |
Extended signal handling to include Windows Ctrl+C support |
Comments suppressed due to low confidence (2)
src/BuiltInTools/dotnet-watch/Utilities/ProcessUtilities.cs:81
- The .NET version 'NET10_0_OR_GREATER' does not exist. Consider using a valid .NET version like 'NET8_0_OR_GREATER' or 'NET9_0_OR_GREATER'.
#if NET10_0_OR_GREATER
src/BuiltInTools/DotNetDeltaApplier/StartupHook.cs:91
- The .NET version 'NET10_0_OR_GREATER' does not exist. Consider using a valid .NET version like 'NET8_0_OR_GREATER' or 'NET9_0_OR_GREATER'.
#if NET10_0_OR_GREATER
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use API added by dotnet/runtime#44944 to enable sending Ctrl+C to child processes on Windows.
Only uses this flag for application processes launched by dotnet-watch (not for auxiliary processes like
dotnet build).