Add 'RunCsWinRTGenerator' task and target #49417
Open
+434
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
commented
Jun 16, 2025
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Windows.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Windows.targets
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Windows.targets
Show resolved
Hide resolved
Sergio0694
commented
Jun 24, 2025
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Windows.targets
Outdated
Show resolved
Hide resolved
8931b3e to
b9d1b7a
Compare
This was referenced Jul 4, 2025
50992cc to
e520c9e
Compare
This was referenced Jul 10, 2025
Also fix incrementality for 'cswinrtgen'
e40a0c5 to
3e38237
Compare
manodasanW
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds infrastructure for CsWinRT 3.0 support by introducing a new MSBuild task and target for running the cswinrtgen tool. The feature is opt-in and disabled by default to support the preview nature of CsWinRT 3.0.
Key Changes:
- Added
RunCsWinRTGeneratorMSBuild task that wraps thecswinrtgentool execution - Created
_RunCsWinRTGeneratortarget with incremental build support and proper dependency management - Implemented automatic tool path resolution based on the
WinRT.Runtime.dllassembly location
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Windows.targets | Adds MSBuild targets and properties for CsWinRT generator integration with incremental build support |
| src/Tasks/Microsoft.NET.Build.Tasks/RunCsWinRTGenerator.cs | Implements the MSBuild task that invokes the cswinrtgen tool with comprehensive parameter validation |
Comments suppressed due to low confidence (1)
src/Tasks/Microsoft.NET.Build.Tasks/RunCsWinRTGenerator.cs:109
- NET10_0_OR_GREATER is not a valid .NET target framework version. The highest released version as of my knowledge cutoff is .NET 8.0. Consider using NET8_0_OR_GREATER or remove this conditional compilation if it's intended for future versions.
#if NET10_0_OR_GREATER
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Windows.targets
Show resolved
Hide resolved
| } | ||
|
|
||
| if (CsWinRTToolsArchitecture is not null && | ||
| !CsWinRTToolsArchitecture.Equals("x86", StringComparison.OrdinalIgnoreCase) && |
There was a problem hiding this comment.
[nitpick] The architecture validation logic could be simplified using a collection-based approach. Consider using a HashSet or array with Contains() for better maintainability.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds supporting infra for CsWinRT 3.0 (see here):
RunCsWinRTGeneratortask that runscswinrtgenEverything is opt-in and off-by-default.