Fix handling of runtimeconfig files in incremental builds #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
approved these changes
Dec 14, 2016
|
@nguerrera @srivatsn Can you review/validate this please? |
|
@MattGertz Code looks good. Getting set up to test. |
|
Let's file a separate bug for the extra things I noted in #471:
I do think it's the right call to scope the change as you have for a servicing fix. |
srivatsn
approved these changes
Dec 14, 2016
|
Changed the PR to target the dev15-rc2 branch. |
Oops. Thanks. |
|
@nguerrera I've filed #496 and #497 for the follow-up issues |
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #471