Skip to content

Fix GenerateLayout target dependencies when skipping crossgen #46979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

Fix GenerateLayout target dependencies when skipping crossgen #46979

merged 1 commit into from
Feb 20, 2025

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Feb 20, 2025 •
edited
Loading

Fixes dotnet/source-build#4904

The Crossgen.targets file must be imported because the GenerateLayout target depends on the CrossgenLayout target in it.

Copilot
Copilot AI reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • src/Installer/redist-installer/Directory.Build.targets: Language not supported
  • src/Installer/redist-installer/targets/Crossgen.targets: Language not supported

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Feb 20, 2025
@ViktorHofer ViktorHofer enabled auto-merge (squash) February 20, 2025 09:32
@ViktorHofer ViktorHofer mentioned this pull request Feb 20, 2025
Closed
@ViktorHofer
Copy link
Member Author

/backport to release/10.0.1xx-preview2

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/10.0.1xx-preview2: https://github.com/dotnet/sdk/actions/runs/13432256875

@github-actions github-actions bot mentioned this pull request Feb 20, 2025
Merged
@ViktorHofer ViktorHofer merged commit 531b748 into dotnet:main Feb 20, 2025
42 checks passed
@ViktorHofer ViktorHofer deleted the FixCrossgenSkipping branch February 20, 2025 14:59
@rnelson rnelson mentioned this pull request Apr 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[main] source-build-lite pipeline is failing due to missing CrossgenLayout targets file
2 participants
@ViktorHofer @akoeplinger