Use package download in generate layout #46925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove DownloadPackage.csproj and support files - Remove SetupBundledComponents target in favor of evaluation so that packages can be restored via PackageDownload - Remove dead properties
b5ada93 to
6183c7e
Compare
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (11)
- sdk.sln: Language not supported
- source-build.slnf: Language not supported
- src/Installer/pkg/dotnet-sdk.proj: Language not supported
- src/Installer/redist-installer/projects/Directory.Build.props: Language not supported
- src/Installer/redist-installer/projects/Directory.Build.targets: Language not supported
- src/Installer/redist-installer/projects/DownloadPackage.csproj: Language not supported
- src/Installer/redist-installer/redist-installer.proj: Language not supported
- src/Installer/redist-installer/targets/BundledManifests.targets: Language not supported
- src/Installer/redist-installer/targets/BundledTemplates.targets: Language not supported
- src/Installer/redist-installer/targets/GenerateBundledVersions.targets: Language not supported
- src/Installer/redist-installer/targets/GenerateLayout.targets: Language not supported
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation: I used WinDiff to compare the
artifacts\bin\redist-installerdirectories before and after this change. The only changes are:Before, the
redist-installerproject created an assembly including support files. It's correct to not produce that assembly anymore.The nuget templates are different. That doesn't seem related to this change as the packages build before redist-installer and the content diff only shows marginal metadata differences.