Add signing parameter to ci pipelines #46368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Jan 28, 2025
jkoritzinsky
approved these changes
Jan 28, 2025
|
Test runs looks reasonable at this point |
premun
reviewed
Jan 29, 2025
| - name: signEnabled | ||
| value: true | ||
| # Pass sign on the internal project if the, branch is a main or release branch | ||
| - ${{ elseif and(eq(variables['System.TeamProject'], 'internal'), or(eq(variables['Build.SourceBranch'], 'refs/heads/main'), startsWith(variables['Build.SourceBranchName'], 'refs/heads/release/'))) }}: |
There was a problem hiding this comment.
How about internal release branches?
There was a problem hiding this comment.
If we decide to sign internal release branches, is there a need to enable signing for the corresponding public release branch? If not, maybe we should sign on the internal project if the branch is main, a preview release branch, or an internal release branch.
There was a problem hiding this comment.
Changed to sign internal/* and release/NN-previewN
|
Minimal change since last iteration that doesn't affect the CI, merging |
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.