-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Migrate sdk's sign/publish infra to use the Artifacts extension point #46341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With improvements in infrastructure, we can utilize the new Artifact extension point to handle checksum generation and blob placement without calling PushToBuildStorage manually. Also, there were two separate places where the repo was persisting the non-shipping version number (from before the sdk and installer merge). Update the build to only persist it once and read it in an evaluation-time manner.
ViktorHofer
reviewed
Jan 27, 2025
ViktorHofer
reviewed
Jan 27, 2025
ViktorHofer
reviewed
Jan 27, 2025
ViktorHofer
reviewed
Jan 27, 2025
ViktorHofer
reviewed
Jan 27, 2025
ViktorHofer
reviewed
Jan 27, 2025
ViktorHofer
reviewed
Jan 27, 2025
Looks good 👍 |
This was referenced Jan 28, 2025
ViktorHofer
approved these changes
Jan 28, 2025
This was referenced Jan 28, 2025
Open
ViktorHofer
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a few commits to fix issues that were reported in CI. Hope that's OK.
jkoritzinsky
commented
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With improvements in infrastructure, we can utilize the new Artifact extension point to handle checksum generation and blob placement without calling PushToBuildStorage manually.
Also, there were two separate places where the repo was persisting the non-shipping version number (from before the sdk and installer merge). Update the build to only persist it once and read it in an evaluation-time manner.