Skip to content

Migrate sdk's sign/publish infra to use the Artifacts extension point #46341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 28, 2025

Conversation

jkoritzinsky
Copy link
Member

With improvements in infrastructure, we can utilize the new Artifact extension point to handle checksum generation and blob placement without calling PushToBuildStorage manually.

Also, there were two separate places where the repo was persisting the non-shipping version number (from before the sdk and installer merge). Update the build to only persist it once and read it in an evaluation-time manner.

With improvements in infrastructure, we can utilize the new Artifact extension point to handle checksum generation and blob placement without calling PushToBuildStorage manually.

Also, there were two separate places where the repo was persisting the non-shipping version number (from before the sdk and installer merge). Update the build to only persist it once and read it in an evaluation-time manner.
@ghost ghost added the untriaged Request triage from a team member label Jan 27, 2025
@ViktorHofer
Copy link
Member

Looks good 👍

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a few commits to fix issues that were reported in CI. Hope that's OK.

@jkoritzinsky jkoritzinsky enabled auto-merge (squash) January 28, 2025 19:23
@jkoritzinsky jkoritzinsky merged commit 8823927 into dotnet:main Jan 28, 2025
36 of 38 checks passed
@jkoritzinsky jkoritzinsky deleted the artifacts-flow branch January 31, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants