Remove auditSources section #42706
Merged
Remove auditSources section #42706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
approved these changes
Aug 13, 2024
This was referenced Aug 14, 2024
| Date: Tue, 13 Aug 2024 18:57:27 +0000 | ||
| Subject: [PATCH] Remove auditSources section | ||
|
|
||
| Tracking: https://github.com/dotnet/source-build/issues/4548 |
There was a problem hiding this comment.
For future reference the convention is Backport: as documented in the patch guidance. Also the referenced issue/PR should track the work to remove the patch. This issue was just closed by this PR. What issue is tracking the long term fix?
|
/backport to release/9.0.1xx |
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/10420699365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nuget.client introduced source auditing with #42658, see NuGet/NuGet.Client#5939
This breaks source build, offline legs, as we do not use any online sources in those scenarios, and do not have internet access, see: dotnet/source-build#4548
This PR adds a patch, to remove
auditSourcessection. - doing this to quickly unblock the VMR build.Will create an issue to track the actual fix, to dynamically remove this section in VMR build.