[main] Revert "[Android, iOS] Dynamically setting SearchHandler Query property does not update text in the search box (#28400)" #30250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR backports the revert of dynamic updates to the SearchHandler.Query property on Android and iOS, removing associated tests and handler logic.
- Disable the failing Issue29492 test on both Windows and iOS
- Remove the shared and host app UI tests for Issue14497
- Strip out the dynamic text‐update branches from the iOS and Android
SearchHandlerAppearanceTracker
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29492.cs | Expand the test exclusion to iOS |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue14497.cs | Remove the shared test for dynamic SearchHandler behavior |
| src/Controls/tests/TestCases.HostApp/Issues/Issue14497.cs | Remove the host‐app UI for dynamic SearchHandler behavior |
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs | Remove QueryProperty and CharacterSpacingProperty update logic |
| src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs | Remove QueryProperty update logic and UpdateText helper |
Comments suppressed due to low confidence (2)
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs:115
- Removing this dynamic update branch changes the public behavior of the
SearchHandler.Queryproperty and may be a breaking change; please confirm this is acceptable for a minor release.
{
mattleibow
previously approved these changes
Jun 26, 2025
bhavanesh2001
approved these changes
Jun 27, 2025
There was a problem hiding this comment.
Should #30166 be closed then?
Rethink things as described here? #30166 (review)
jsuarezruiz
previously approved these changes
Jun 27, 2025
…ty does not update text in the search box (#28400)" This reverts commit 559da79. # Conflicts: # src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs # src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs # src/Controls/tests/TestCases.HostApp/Issues/Issue14497.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue14497.cs
…rty (#29497)" This reverts commit 9827339. # Conflicts: # src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs # src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs # src/Controls/tests/TestCases.HostApp/Issues/Issue29492.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29492.cs
c4531bb
8432e4d to
c4531bb
Compare
rmarinho
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #30222 to main
/cc @PureWeen