Skip to content

[NET10.0] [Windows] Filenames contain uwp even though UWP is not the technology used - FIX #29750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 17, 2025
Merged

[NET10.0] [Windows] Filenames contain uwp even though UWP is not the technology used - FIX #29750

merged 7 commits into from
Jun 17, 2025

Conversation

MartyIX
Copy link
Contributor

@MartyIX MartyIX commented May 30, 2025 •
edited
Loading

Description of Change

Rename *.uwp.cs files to *.windows.cs for clarity. Commits should be easy to follow one by one.

Issues Fixed

Fixes #29749

@MartyIX MartyIX requested a review from a team as a code owner May 30, 2025 13:27
@MartyIX MartyIX changed the title [NET10.0] [Windows] Filenames contain uwp even though UWP is not the technology used - FIX [NET10.0] [Windows] Filenames contain uwp even though UWP is not the technology used - FIX May 30, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label May 30, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jfversluis
jfversluis requested changes Jun 4, 2025
View reviewed changes
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all other files have the platform lowercase 🫣

But other than that, seems good to me!

@MartyIX
Copy link
Contributor Author

MartyIX commented Jun 4, 2025 •
edited
Loading

I think all other files have the platform lowercase 🫣

I changed it.

Note that many other files have Windows capitalized: image but it can be unified later for all platforms. Essentials project seems to be an exception.

@rmarinho rmarinho requested review from mattleibow and removed request for tj-devel709 June 4, 2025 12:53
@rmarinho
Copy link
Member

rmarinho commented Jun 4, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho requested a review from jfversluis June 4, 2025 14:43
rmarinho
rmarinho approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we might want to make another PR to change the others to .windows :)

@PureWeen PureWeen added this to the .NET 10.0-preview6 milestone Jun 10, 2025
PureWeen
PureWeen requested changes Jun 10, 2025
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to discuss this a bit more internally @mattleibow

@github-project-automation github-project-automation bot moved this from Todo to Changes Requested in MAUI SDK Ongoing Jun 10, 2025
@jsuarezruiz jsuarezruiz self-requested a review June 16, 2025 15:18
@rmarinho rmarinho merged commit 2c1df44 into dotnet:net10.0 Jun 17, 2025
129 checks passed
@github-project-automation github-project-automation bot moved this from Changes Requested to Done in MAUI SDK Ongoing Jun 17, 2025
@MartyIX MartyIX deleted the feature/2025-05-30-so-long-uwp branch June 17, 2025 08:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen requested changes

@rmarinho rmarinho rmarinho approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@mattleibow mattleibow Awaiting requested review from mattleibow

@jfversluis jfversluis Awaiting requested review from jfversluis

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

Assignees
No one assigned
Labels
community ✨ Community Contribution
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 10.0-preview6
Development

Successfully merging this pull request may close these issues.
5 participants
@MartyIX @jsuarezruiz @rmarinho @jfversluis @PureWeen