Skip to content

Fixed Test case failure in PR 29469 - [2025/05/26] #29688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented May 27, 2025

Fixes #29623

@kubaflo kubaflo requested a review from a team as a code owner May 27, 2025 08:56
@kubaflo kubaflo requested review from mattleibow and rmarinho and removed request for a team May 27, 2025 08:56
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label May 27, 2025
Copy link
Contributor

Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@rmarinho
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

ContentOffset = new CGPoint(horizontalOffset, 0);
}
else
if (_previousEffectiveUserInterfaceLayoutDirection != EffectiveUserInterfaceLayoutDirection)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment why we need to save the state?

Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kubaflo can you add more info to the description, like what test is this fixing , and maybe add a comment why we need to save the state for EffectiveUserInterfaceLayoutDirection

@kubaflo
Copy link
Contributor Author

kubaflo commented May 27, 2025

@rmarinho sure thing! done :)

@rmarinho
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit 4ecc0d9 into dotnet:inflight/candidate May 28, 2025
123 of 129 checks passed
github-actions bot pushed a commit that referenced this pull request May 30, 2025
* Fixed Test case failure in PR 29469 - [2025/05/26]

* Fixed Test case failure in PR 29469 - [2025/05/26]
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community ✨ Community Contribution test-flight
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants