-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixed Test case failure in PR 29469 - [2025/05/26] #29688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Test case failure in PR 29469 - [2025/05/26] #29688
Conversation
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
ContentOffset = new CGPoint(horizontalOffset, 0); | ||
} | ||
else | ||
if (_previousEffectiveUserInterfaceLayoutDirection != EffectiveUserInterfaceLayoutDirection) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment why we need to save the state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kubaflo can you add more info to the description, like what test is this fixing , and maybe add a comment why we need to save the state for EffectiveUserInterfaceLayoutDirection
@rmarinho sure thing! done :) |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
* Fixed Test case failure in PR 29469 - [2025/05/26] * Fixed Test case failure in PR 29469 - [2025/05/26]
Fixes #29623