[Catalyst] Click-Dragging Behavior in CollectionView #29616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Pull Request Overview
This PR restores a more responsive drag-and-drop experience on Mac Catalyst by reducing the long-press threshold to 0.1 seconds.
- Adds a
#if MACCATALYSTblock to setMinimumPressDurationto0.1seconds in both reorderable view controllers. - Ensures drag gestures match original system behavior without requiring a full long press.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Controls/src/Core/Handlers/Items2/iOS/ReorderableItemsViewController2.cs | Add MACCATALYST-specific MinimumPressDuration adjustment to the long-press gesture recognizer. |
| src/Controls/src/Core/Handlers/Items/iOS/ReorderableItemsViewController.cs | Add MACCATALYST-specific MinimumPressDuration adjustment to the long-press gesture recognizer. |
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Handlers/Items2/iOS/ReorderableItemsViewController2.cs:169
- Add automated UI tests in
TestCases.Shared.TestsandTestCases.HostAppto verify the reduced press duration behavior on Mac Catalyst and ensure tests run reliably against the new gesture timing.
_longPressGestureRecognizer.MinimumPressDuration = 0.1;
src/Controls/src/Core/Handlers/Items2/iOS/ReorderableItemsViewController2.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Handlers/Items2/iOS/ReorderableItemsViewController2.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
May 23, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
* CollectionView drag changes on Mac * Mac drag changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #29536
Tested the behaviour in the following platforms
Screenshot
Before-Fix.mov
After-Fix.mov