[C] Fix typo #29379
Merged
[C] Fix typo #29379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
major facepalm - fixes #29336
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typo that caused an incorrect type check in the core binding logic and adds tests to validate the ItemDisplayBinding functionality.
- Added unit tests for ItemDisplayBinding in a new test class.
- Fixed the type check in BindableObject.cs by replacing BindableProperty with BindingBase.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/tests/Core.UnitTests/ItemDisplayBindingTests.cs | New unit tests for the ItemDisplayBinding property in a test view. |
| src/Controls/src/Core/BindableObject.cs | Corrected a type check to use BindingBase instead of BindableProperty to fix a bug. |
Comments suppressed due to low confidence (1)
src/Controls/src/Core/BindableObject.cs:485
- The corrected type check now uses BindingBase instead of BindableProperty, which should resolve the type mismatch issue. Please verify that this change fully addresses the misassignment bug observed in production.
if (value is BindingBase binding && !property.ReturnType.IsAssignableFrom(typeof(BindingBase)))
StephaneDelcroix
commented
May 7, 2025
| @@ -482,7 +482,7 @@ public void SetValue(BindableProperty property, object value) | |||
| if (property == null) | |||
| throw new ArgumentNullException(nameof(property)); | |||
|
|
|||
| if (value is BindingBase binding && !property.ReturnType.IsAssignableFrom(typeof(BindableProperty))) | |||
| if (value is BindingBase binding && !property.ReturnType.IsAssignableFrom(typeof(BindingBase))) | |||
There was a problem hiding this comment.
when we set BP of type BindingBase, we do not SetBinding, we SetValue. XAML inflators are doing this right, and it only happens when used in code. this is why it was never caught
rmarinho
previously approved these changes
May 8, 2025
PureWeen
approved these changes
May 8, 2025
PureWeen
pushed a commit
that referenced
this pull request
May 9, 2025
major facepalm - fixes #29336
PureWeen
pushed a commit
that referenced
this pull request
May 13, 2025
major facepalm - fixes #29336
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2025
major facepalm - fixes #29336
PureWeen
pushed a commit
that referenced
this pull request
May 14, 2025
major facepalm - fixes #29336
PureWeen
pushed a commit
that referenced
this pull request
May 14, 2025
major facepalm - fixes #29336
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2025
major facepalm - fixes #29336
PureWeen
added a commit
that referenced
this pull request
May 21, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes ## New Release: May 21, 2025 We're excited to announce a new release of .NET MAUI with several bug fixes and improvements across various platforms. ### Bug Fixes #### iOS - **Map Control**: Fixed crash when navigating to a page containing a map more than once (#29369) - **CarouselView**: Fixed bounce-back behavior when Loop=false, ensuring proper scrolling experience (#29318) - **UIView**: Fixed NullReferenceException for UIView not being in UIWindow (#29460) #### Windows - **CarouselView**: Fixed HorizontalScrollBarVisibility="Never" not working properly (#29343) - **UI Controls**: Fixed the color not being applied to the Expand/Collapse Chevron icon (#29140) #### Windows & macOS - **Modal Navigation**: Fixed issue where Disappearing event was not triggered when closing a window with a modal page (#29129) #### Android - **Modal Pages**: Improved inheritance of StatusBar and NavigationBar background colors (#28568) - **Footer Scrolling**: Fixed footer scrolling issues in list controls (#29381) - **Modal Pages**: Improved inheritance of StatusBar and NavigationBar background colors on modal pages (#28568) #### Cross-Platform - **CarouselView**: Fixed ItemsLayout runtime updates to ensure proper layout behavior (#29447) - **CollectionView**: Fixed various issues in CollectionView implementation (#29423) ### Testing Improvements - Added feature matrix UITest cases for CollectionView dynamic changes (#29424) ### Code Quality - Fixed code formatting issues across the codebase - Minor typo corrections (#29379) ### Contributors This release was made possible by the hard work of our dedicated team and community contributors. We'd like to extend our gratitude to everyone who has contributed to this release. ### Installation This update is available through NuGet and the .NET SDK. Update your projects to get access to these fixes. ### Known Issues Please refer to our issue tracker for any known issues and their workarounds. --- For more information about .NET MAUI, visit [the official documentation](https://docs.microsoft.com/dotnet/maui/).
PureWeen
pushed a commit
that referenced
this pull request
May 21, 2025
major facepalm - fixes #29336
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
major facepalm
Issues Fixed