Fixes footer position not updated on CV1 when clearing all items #29173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
previously approved these changes
Apr 24, 2025
|
|
||
| // Now let's add items until the footer goes out of the screen | ||
| // and then remove them all and verify the footer is visible again (#29137) | ||
| var add2Items = App.WaitForElement("Add 2 Items"); |
There was a problem hiding this comment.
Test fails on Android. The exception suggests that the footer might be getting re-rendered/removed/out of screen when items are added.
There was a problem hiding this comment.
@bhavanesh2001 yeah, thanks, I've fixed the UITest and made it more reliable.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Apr 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Now that #28479 prevents the invalidation to propagate up the collection view when a cell has fixed constraints, there was nothing triggering re-layout of CV1 footer while unbinding cells.
This PR marks the CV to be updated when we unbind a cell.
Issues Fixed
Fixes #29137