Skip to content

Fix iOS Label being truncated when using Padding #29031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

Fix iOS Label being truncated when using Padding #29031

merged 1 commit into from
May 29, 2025

Conversation

albyrock87
Copy link
Contributor

Description of Change

Fixes iOS Label being truncated when using padding under some conditions.

Issues Fixed

Fixes #28180

@albyrock87 albyrock87 requested a review from a team as a code owner April 16, 2025 15:04
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 16, 2025
albyrock87
albyrock87 commented Apr 16, 2025
View reviewed changes
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Ahamed-Ali Ahamed-Ali mentioned this pull request Apr 21, 2025
Merged
@PureWeen PureWeen added this to the .NET 9 SR8 milestone May 14, 2025
@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing May 14, 2025
@mattleibow
Copy link
Member

/rebase

@github-actions github-actions bot force-pushed the fix-ios-maui-label-padding branch from 506974d to 5ce1591 Compare May 23, 2025 17:01
@mattleibow mattleibow changed the base branch from main to inflight/current May 23, 2025 17:03
@mattleibow mattleibow changed the base branch from inflight/current to main May 23, 2025 17:04
@mattleibow
Copy link
Member

@albyrock87 I see this PR is for a closed issue. Is this a new issue that was introduced or a refinement of the fix?

Is there a better issue to reference?

@mattleibow
Copy link
Member

@Dhivya-SF4094 FYI

mattleibow
mattleibow requested changes May 23, 2025
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just marking red so I can make sure that this is correct after the PR for the same issue.

@github-project-automation github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing May 23, 2025
@albyrock87
Copy link
Contributor Author

@mattleibow this is a refinement of that fix which didn't fully cover the topic.

@albyrock87 albyrock87 force-pushed the fix-ios-maui-label-padding branch from 5ce1591 to 8912a80 Compare May 26, 2025 13:51
@albyrock87 albyrock87 force-pushed the fix-ios-maui-label-padding branch from 8912a80 to 7b83b49 Compare May 26, 2025 13:52
@albyrock87
Copy link
Contributor Author

@mattleibow I should have addressed your concerns

@github-project-automation github-project-automation bot moved this from Changes Requested to Approved in MAUI SDK Ongoing May 27, 2025
@rmarinho
Copy link
Member

/azp run MAUI-DeviceTests-public

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot May 29, 2025
@dotnet dotnet deleted a comment from azure-pipelines bot May 29, 2025
@dotnet dotnet deleted a comment from mattleibow May 29, 2025
@dotnet dotnet deleted a comment from PureWeen May 29, 2025
@rmarinho
Copy link
Member

Seems this was fixed by #28081

@rmarinho rmarinho closed this May 29, 2025
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing May 29, 2025
@rmarinho rmarinho reopened this May 29, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in MAUI SDK Ongoing May 29, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Approved in MAUI SDK Ongoing May 29, 2025
@rmarinho rmarinho changed the base branch from main to inflight/candidate May 29, 2025 10:57
@rmarinho rmarinho merged commit d17804e into dotnet:inflight/candidate May 29, 2025
77 of 120 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing May 29, 2025
github-actions bot pushed a commit that referenced this pull request May 30, 2025
@albyrock87 @rmarinho
Fix iOS Label being truncated when using Padding (#29031)
5dcbaed
@LogishaSelvarajSF4525 LogishaSelvarajSF4525 mentioned this pull request May 30, 2025
Merged
@anandhan-rajagopal anandhan-rajagopal mentioned this pull request Jun 2, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@rmarinho rmarinho rmarinho approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@PureWeen PureWeen Awaiting requested review from PureWeen PureWeen is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-controls-label Label, Span community ✨ Community Contribution platform/ios
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 9 SR8
Development

Successfully merging this pull request may close these issues.

Labels with Padding are truncated on IOS
5 participants
@albyrock87 @mattleibow @rmarinho @PureWeen @jsuarezruiz